grammar/wording updates #106
Conversation
ffv1.md
Outdated
| @@ -1111,7 +1111,7 @@ If state_transition_delta is not present in the FFV1 bitstream, all Range coder | |||
| | Other | reserved for future use | reserved for future use | reserved for future use | | |||
|
|
|||
| Restrictions: | |||
| If `colorspace_type` is 1, `chroma_planes` MUST be 1, `h_chroma_subsample` MUST be 1, `v_chroma_subsample` MUST be 1. | |||
| If `colorspace_type` is 1, then `chroma_planes` MUST be 1, `h_chroma_subsample` MUST be 1, and `v_chroma_subsample` MUST be 1. | |||
There was a problem hiding this comment.
I missed this one in the patch about chroma_planes, but should actually be log2_h_chroma_subsample and log2_v_chroma_subsample
There was a problem hiding this comment.
not log2(h_chroma_subsample)?
There was a problem hiding this comment.
no, we changed it.
check Parameters( ) pseudo-code log2_h_chroma_subsample definition part
There was a problem hiding this comment.
fixed in a second commit, thx for catching this.
|
+If shouldnt this be 0 ? |
I confirm, typo during move to |
dericed
force-pushed
the
sentence-fix
branch
from
d08e818
to
acbf537
Compare
|
Updated to 0, please re-review. |
|
bump on this, is there something blocking? IMO it is good to have such correction from a native English speaker. |
|
any reason why still unmerged? need more demonstration of consensus or are more changes suggested. |
No description provided.