-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grammar/wording updates #106
Conversation
ffv1.md
Outdated
@@ -1111,7 +1111,7 @@ If state_transition_delta is not present in the FFV1 bitstream, all Range coder | |||
| Other | reserved for future use | reserved for future use | reserved for future use | | |||
Restrictions: | |||
If `colorspace_type` is 1, `chroma_planes` MUST be 1, `h_chroma_subsample` MUST be 1, `v_chroma_subsample` MUST be 1. | |||
If `colorspace_type` is 1, then `chroma_planes` MUST be 1, `h_chroma_subsample` MUST be 1, and `v_chroma_subsample` MUST be 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this one in the patch about chroma_planes, but should actually be log2_h_chroma_subsample
and log2_v_chroma_subsample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not log2(h_chroma_subsample)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we changed it.
check Parameters( )
pseudo-code log2_h_chroma_subsample
definition part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in a second commit, thx for catching this.
+If shouldnt this be 0 ? |
I confirm, typo during move to |
d08e818
to
acbf537
Compare
Updated to 0, please re-review. |
bump on this, is there something blocking? IMO it is good to have such correction from a native English speaker. |
any reason why still unmerged? need more demonstration of consensus or are more changes suggested. |
No description provided.